fix: correct bytecode placeholder replacement length #12656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilogweb3
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
strip_bytecode_placeholdersfunction was replacing 40-character libraryplaceholders with 80 hex characters instead of 40. This doubled the expectedsize and would corrupt the bytecode structure.Library placeholders like
__$987e73aeca5e61ce83e4cb0814d87beda9$__are 40 chars (equivalent to a 20-byte address in hex). The replacement needs to match this length to preserve bytecode integrity.Changed
"00".repeat(40)to"00".repeat(20)which produces 40 hex chars.